Messages in this thread | | | Date | Wed, 13 Dec 2017 11:19:06 -0700 | From | Jason Gunthorpe <> | Subject | Re: infiniband: cxgb4: use ktime_get for timestamps |
| |
On Mon, Nov 27, 2017 at 12:44:53PM +0100, Arnd Bergmann wrote: > The debugfs file prints the difference between host timestamps as a > seconds/nanoseconds tuple, along with a 64-bit nanoseconds hardware > timestamp. The host time is read using getnstimeofday() which is > deprecated because of the y2038 overflow, and it suffers from time jumps > during settimeofday() and leap seconds. > > Converting to ktime_get_ts64() would solve those two, but I'm going > a little further here by changing to ktime_get() and printing 64-bit > nanoseconds on both host and hw timestamps. This simplifies the code > further and makes the output easier to understand. > > The format of the debugfs file obviously changes here, but this should > only be read by humans and not scripts, so I assume it's fine. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Steve Wise <swise@opengridcomputing.com> > drivers/infiniband/hw/cxgb4/device.c | 34 +++++++++++++++------------------- > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 ++-- > drivers/infiniband/hw/cxgb4/qp.c | 6 +++--- > drivers/infiniband/hw/cxgb4/t4.h | 4 ++-- > 4 files changed, 22 insertions(+), 26 deletions(-)
Thanks, applied to -next
Jason
| |