Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 13 Dec 2017 16:46:10 +0100 | Subject | Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled |
| |
2017-12-13 16:39 GMT+01:00 Mark Brown <broonie@kernel.org>: > On Wed, Dec 13, 2017 at 10:28:11AM +0100, Bartosz Golaszewski wrote: >> User space can initiate concurrent access to regmap over debugfs and, >> if the locking is disabled, we can't protect it. Don't create the >> debugfs entries at all in this case. > > I (probably unsurprisingly) prefer my version that I posted yesterday as > it gives us the trivial memory saving of not having the flag if debugfs > is disabled but more importantly from my point of view keeps the > interface to debugfs as function calls in the core.
It went into spam in my mailbox for some reason, that's why I didn't see it.
Yes, it looks better. I'll drop it from the series.
Thanks, Bartosz
| |