Messages in this thread | | | Subject | Re: [PATCH v5 10/15] soundwire: Add sysfs for SoundWire DisCo properties | From | Pierre-Louis Bossart <> | Date | Wed, 13 Dec 2017 08:31:35 -0600 |
| |
On 12/13/2017 03:54 AM, Vinod Koul wrote: > >>> + * Base file is: >>> + * properties >>> + * |---- interface-revision >>> + * |---- master-count >>> + * |---- link-N >>> + * |---- clock-stop-modes >>> + * |---- max-clock-frequency >>> + * |---- clock-frequencies >>> + * |---- default-frame-rows >>> + * |---- default-frame-cols >>> + * |---- dynamic-frame-shape >>> + * |---- command-error-threshold >>> + */ >> Why nest them so deep? Anyway, that's not really an issue I guess, it's >> your ABI, not mine :) > well it gives us a hierarchical view. We have N links... The property definitions follows the MIPI DisCo spec, there's no real creativity here. That said, Vinod you need to remove the master-count - as discussed on the other patch where this property is read this is not relevant for a master if you don't have a representation of a controller.
| |