Messages in this thread | | | Date | Wed, 13 Dec 2017 15:30:27 +0300 | From | Mikhail Zaytsev <> | Subject | Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl |
| |
On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum <oneukum@suse.com> wrote:
> They give you nothing. If you are looking at a vendor ID nothing but the > bare number makes sense. You are just making peoples' life harder when > they have to look up that definition. A symbolic name is fine if it gives > meaning. Even if the information you give is that the value is magic > and therefore not understood. But a vendor ID is an arbitrary yet > meaningful number. There is no point in hiding it.
Thanks. I hear you, Oliver. What about:
- serstruct.baud_base = 460800;
Is it a magic number? I think yes.
-- Mikhail
| |