lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling
From
Date
Hello!

On 12/13/2017 9:27 AM, Yoshihiro Shimoda wrote:

> This patch unifies the OBINTEN handling to clean-up the code.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> index c22d65a..beeaa30 100644
> --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> @@ -147,6 +147,18 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
> writel(val, usb2_base + USB2_ADPCTRL);
> }
>
> +static void rcar_gen3_enable_otg_irq(struct rcar_gen3_chan *ch, int enable)

If it both enables and disables, rcar_gen3_control_otg_irq() would seem a
better name...

> +{
> + void __iomem *usb2_base = ch->base;
> + u32 val = readl(usb2_base + USB2_OBINTEN);
> +
> + if (enable)
> + val |= USB2_OBINT_BITS;
> + else
> + val &= ~USB2_OBINT_BITS;
> + writel(val, usb2_base + USB2_OBINTEN);
> +}
> +
> static void rcar_gen3_init_for_host(struct rcar_gen3_chan *ch)
> {
> rcar_gen3_set_linectrl(ch, 1, 1);
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2017-12-13 10:10    [W:0.059 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site