Messages in this thread | | | Date | Wed, 13 Dec 2017 14:36:23 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter |
| |
On 12-12-17, 15:16, Patrick Bellasi wrote: > Since you are already changing some flags position, maybe we can have > a better organization by using lower flags for "general bits" and > higher ones for class specific, i.e. > > #define SCHED_CPUFREQ_CLEAR (1U << 0) > #define SCHED_CPUFREQ_IOWAIT (1U << 1) > > #define SCHED_CPUFREQ_CFS (1U << 8) > #define SCHED_CPUFREQ_RT (1U << 9) > #define SCHED_CPUFREQ_DL (1U << 10)
Since we aren't normally going to add any more of class specific ones, I would like to keep them as 0, 1 and 2. And using the top most bit for CLEAR seems better to me somehow, just like the signed bit for 32 bit integers.
-- viresh
| |