lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 106/164] net/smc: use sk_rcvbuf as start for rmb creation
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ursula Braun <ursula.braun@de.ibm.com>


    [ Upstream commit 4e1061f4a2bba1669c7297455c73ddafbebf2b12 ]

    Commit 3e034725c0d8 ("net/smc: common functions for RMBs and send buffers")
    merged handling of SMC receive and send buffers. It introduced sk_buf_size
    as merged start value for size determination. But since sk_buf_size is not
    used at all, sk_sndbuf is erroneously used as start for rmb creation.
    This patch makes sure, sk_buf_size is really used as intended, and
    sk_rcvbuf is used as start value for rmb creation.

    Fixes: 3e034725c0d8 ("net/smc: common functions for RMBs and send buffers")
    Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
    Reviewed-by: Hans Wippel <hwippel@linux.vnet.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/smc/smc_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/smc/smc_core.c
    +++ b/net/smc/smc_core.c
    @@ -571,7 +571,7 @@ static int __smc_buf_create(struct smc_s
    /* use socket send buffer size (w/o overhead) as start value */
    sk_buf_size = smc->sk.sk_sndbuf / 2;

    - for (bufsize_short = smc_compress_bufsize(smc->sk.sk_sndbuf / 2);
    + for (bufsize_short = smc_compress_bufsize(sk_buf_size);
    bufsize_short >= 0; bufsize_short--) {

    if (is_rmb) {

    \
     
     \ /
      Last update: 2017-12-12 14:45    [W:3.631 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site