lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 110/164] apparmor: fix leak of null profile name if profile allocation fails
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: John Johansen <john.johansen@canonical.com>


    [ Upstream commit 4633307e5ed6128975595df43f796a10c41d11c1 ]

    Fixes: d07881d2edb0 ("apparmor: move new_null_profile to after profile lookup fns()")
    Reported-by: Seth Arnold <seth.arnold@canonical.com>
    Signed-off-by: John Johansen <john.johansen@canonical.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    security/apparmor/policy.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/security/apparmor/policy.c
    +++ b/security/apparmor/policy.c
    @@ -502,7 +502,7 @@ struct aa_profile *aa_new_null_profile(s
    {
    struct aa_profile *p, *profile;
    const char *bname;
    - char *name;
    + char *name = NULL;

    AA_BUG(!parent);

    @@ -562,6 +562,7 @@ out:
    return profile;

    fail:
    + kfree(name);
    aa_free_profile(profile);
    return NULL;
    }

    \
     
     \ /
      Last update: 2017-12-12 14:41    [W:7.013 / U:0.996 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site