Messages in this thread | | | Date | Wed, 13 Dec 2017 10:48:54 +0900 | From | Andi Shyti <> | Subject | Re: [PATCH] spi: s3c64xx: add SPDX identifier |
| |
Hi Krzysztof,
> > Here, this should be as a top line: > > > > // SPDX-License-Identifier: GPL-2.0+ > > > > > > So I agree with the SPDX id but also pointing to the use of the C++ // > > comment style as requested by Linus [1] > > Thanks for the reference. I see that Linus prefers converting entire > comment into // style. I was not arguing about SPDX line but entire > existing copyright comment which follows it: > > > +// > > +// Copyright (c) 2009 Samsung Electronics Co., Ltd. > > +// Jaswinder Singh <jassi.brar@samsung.com>
it just looks ugly to me to have something like
// SPDX... /* * Copyright (c)... * Jasw... */
I would make everything of the '//' style (I've also seen that this is the trend also in other subsystems), but honestly I don't really care. If you're strong on not moving entirely in '//' style then I can resend it with the double comment style.
Andi
P.S. About GPLv2 vs GPLv2+ I checked and I will repost it keeping the license as its original. Thanks!
| |