Messages in this thread | | | From | Philippe Ombredanne <> | Date | Tue, 12 Dec 2017 23:40:47 +0100 | Subject | Re: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support |
| |
Dear Salil,
On Tue, Dec 12, 2017 at 6:52 PM, Salil Mehta <salil.mehta@huawei.com> wrote: > This patch adds the support of hardware compatibiltiy layer to the > HNS3 VF Driver. This layer implements various {set|get} operations > over MAC address for a virtual port, RSS related configuration, > fetches the link status info from PF, does various VLAN related > configuration over the virtual port, queries the statistics from > the hardware etc. > > This layer can directly interact with hardware through the > IMP(Integrated Mangement Processor) interface or can use mailbox > to interact with the PF driver. > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > Signed-off-by: lipeng <lipeng321@huawei.com> > --- > Patch V3: Addressed SPDX change requested by Philippe Ombredanne > Link: https://lkml.org/lkml/2017/12/8/874 > Patch V2: Addressed some internal comments > Patch V1: Initial Submit > --- > .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 1490 ++++++++++++++++++++ > .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 164 +++ > 2 files changed, 1654 insertions(+) > create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > new file mode 100644 > index 0000000..ff55f4c > --- /dev/null > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c > @@ -0,0 +1,1490 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (c) 2016-2017 Hisilicon Limited. > + */
This is just me nitpicking and this is entirely up to you.... but in such a simple case you could go all the way too:
> +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (c) 2016-2017 Hisilicon Limited.
In this case this can make the thing look more consistent. See also Linus commentaries about this [1][2][3][4]
[1] https://lkml.org/lkml/2017/11/25/133 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/2/715 [4] https://lkml.org/lkml/2017/11/2/805
-- Cordially Philippe Ombredanne
| |