lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/13] irq debug: do not use print_symbol()
    On (12/11/17 12:55), David Laight wrote:
    > > kernel/irq/debug.h | 8 +++-----
    > > 1 file changed, 3 insertions(+), 5 deletions(-)
    > >
    > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h
    > > index 17f05ef8f575..5766e15c1160 100644
    > > --- a/kernel/irq/debug.h
    > > +++ b/kernel/irq/debug.h
    > ...
    > > @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
    > > printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
    > > irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
    > > printk("->handle_irq(): %p, ", desc->handle_irq);
    > > - print_symbol("%s\n", (unsigned long)desc->handle_irq);
    > > + pr_cont("%pS\n", desc->handle_irq);
    >
    > Looks like you can (and should) use a single printk() instead of pr_cont.

    thanks, good point. those pr_cont()-s basically just replicate
    the old behaviour; but it'll be better to get tid of them. will
    follow up shortly.

    -ss

    \
     
     \ /
      Last update: 2017-12-12 03:51    [W:2.302 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site