lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: update i2c-dev.h warning in documentation
On Sat, 9 Dec 2017 23:10:58 +0300
Cengiz Can <cengizc@gmail.com> wrote:

> `dev-interface` document gives examples for accessing i2c from
> userspace.
>
> There's a note warning developers about the different `i2c-dev.h` header
> files which were shipped with the kernel and i2c-tools separately.
>
> However, these commits in i2c-tools repository suggests that the header
> files are now identical (in functionality) and `i2c_*` functions are now
> defined in a separate header called `i2c/smbus.h`, which is distributed
> with i2c-tools:
>
> commit 652619121974 ("Minimize differences with kernel flavor")
> commit 93caf007f4cb ("Move SMBus helper functions to include/i2c/smbus.h")
>
> Thus, I've converted the warning paragraph into a historical note and
> updated the suggested header files.
>
> Signed-off-by: Cengiz Can <cengizc@gmail.com>

So this seems like a worthwhile change, but the patch contains a number of
unrelated changes, mostly white-space stuff it seems. Can you clean that
up and resend?

Thanks,

jon

\
 
 \ /
  Last update: 2017-12-12 00:21    [W:0.069 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site