Messages in this thread | | | Date | Mon, 11 Dec 2017 22:52:26 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: AF_ALG - fix race accessing cipher request |
| |
On Fri, Dec 08, 2017 at 11:50:37AM +0100, Stephan Müller wrote: > Hi Herbert, > > This patch would go on top of 7d2c3f54e6f646887d019faa45f35d6fe9fe82ce > "crypto: af_alg - remove locking in async callback" found in Linus' tree > which is not yet in the cryptodev-2.6 tree. > > In addition, this patch is already on top of the other patches discussed > on this list fixing similar issues. I.e. depending in which order you apply > the patches, there may be a hunk. In case you want me to rebase the patch, > please let me know. > > ---8<--- > When invoking an asynchronous cipher operation, the invocation of the > callback may be performed before the subsequent operations in the > initial code path are invoked. The callback deletes the cipher request > data structure which implies that after the invocation of the > asynchronous cipher operation, this data structure must not be accessed > any more. > > The setting of the return code size with the request data structure must > therefore be moved before the invocation of the asynchronous cipher > operation. > > Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management") > Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management") > Reported-by: syzbot <syzkaller@googlegroups.com> > Cc: <stable@vger.kernel.org> # v4.14+ > Signed-off-by: Stephan Mueller <smueller@chronox.de>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |