lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM
On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote:
> Add manual HW power management to drivers probe/remove in order to
> not fail in a case of runtime power management being disabled in kernel
> config.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/gpu/drm/tegra/dc.c | 164 +++++++++++++++++++++++++++----------------
> drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++---------------
> drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++--------
> drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++----------
> 4 files changed, 310 insertions(+), 185 deletions(-)

I think that's the wrong way around. We unconditionally select PM on
64-bit ARM already, and I think we should do the same on 32-bit ARM.
There's really no excuse not to enable runtime PM these days.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-12-11 11:13    [W:0.183 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site