Messages in this thread | | | Date | Sun, 10 Dec 2017 21:03:03 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH v3 14/14] nubus: Add support for the driver model |
| |
On Thu, 7 Dec 2017, Philippe Ombredanne wrote:
> > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c > > new file mode 100644 > > index 000000000000..b5045e639b4d > > --- /dev/null > > +++ b/drivers/nubus/bus.c > > @@ -0,0 +1,119 @@ > > +/* > > + * Bus implementation for the NuBus subsystem. > > + * > > + * Copyright (C) 2017 Finn Thain > > + * > > + * SPDX-License-Identifier: GPL-2.0 > > + */ > > I think the SPDX id should be on the first line using C++-style // comments.
Sure, why not.
Since Linus has explicitly allowed conversion of the entire block comment to C++ style, I think I may prefer that as being less ugly than the mixture of styles (though fwiw this will always read like top posting to me).
> See tglx's doc patches
I didn't find any mention of SPDX under Documentation...
> and Linus posts explaining why he wants it this way! >
I suspect that you are referring to his posts in this thread (?) https://lkml.org/lkml/2017/11/2/728
--
| |