Messages in this thread | | | Subject | Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver | From | Santosh Shilimkar <> | Date | Fri, 1 Dec 2017 13:58:27 -0800 |
| |
On 12/1/2017 9:54 AM, Tony Lindgren wrote: > * Dave Gerlach <d-gerlach@ti.com> [171130 22:58]: >> This is a resend of v5 of this series found here [1]. It introduces >> relocatable PM handlers for the emif that are copied to sram and >> run from there during low power mode entry. >> >> The patches still have the previous ACKs but have a small change to >> accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts: >> Add missing hwmod related nodes for am33xx"). If there are objections >> to this let me know ASAP. > > Still looks good to me thanks. > >> Now that a hwmod is present for the am335x EMIF, on probe fail the call to >> pm_runtime_put_sync causes the board to hang. In fact, this emif driver should >> never alter the PM state of the hardware at all through normal kernel calls, it >> is the job of the suspend handlers that are added, that is the whole point of >> this driver. Because of this, I have dropped all runtime pm calls, as any >> change to the PM state while the kernel is running is dangerous as we may shut >> of the memory controller. It makes the most sense just to drop runtime PM from >> the driver entirely. Besides that patch is unchanged. > > OK makes sense to me. > Thanks Tony. Will queue this version once rc1 is tagged.
Regards, Santosh
| |