Messages in this thread | | | Subject | Re: [PATCH v2 14/19] ASoC: tlv320aic31xx: Remove regulator notification handling | From | "Andrew F. Davis" <> | Date | Fri, 1 Dec 2017 09:01:19 -0600 |
| |
On 12/01/2017 07:36 AM, Mark Brown wrote: > On Wed, Nov 29, 2017 at 03:32:55PM -0600, Andrew F. Davis wrote: >> A regulator being forcefully disabled is a catastrophic event that >> should never happen to most devices, especially not sound CODECs. > > That's not what the disable notification handling is for. It's there so > that the driver can skip having to reinitialize the device if other > constraints mean the power doesn't actually get turned off when it > disables the regualtors. It's nothing to do with forced disables. >
Looking into the call sites, at least in this case the only time this notification will be called, outside the normal enable/disable paths (which do the same thing here: turn on regmap cache only mode and mark it dirty), will be during a force disable scenario.
| |