lkml.org 
[lkml]   [2017]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties
    From
    Date


    On 19/10/17 04:03, Vinod Koul wrote:
    > It helps to read the properties for understanding and debug
    > SoundWire systems, so add sysfs files for SoundWire DisCo
    > properties.
    >
    > TODO: Add ABI files for sysfs
    >
    > Signed-off-by: Sanyog Kale <sanyog.r.kale@intel.com>
    > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    > ---

    > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
    > index 6c4f41b64744..e3d7aea18892 100644
    > --- a/drivers/soundwire/bus.c
    > +++ b/drivers/soundwire/bus.c
    > @@ -90,6 +90,8 @@ int sdw_add_bus_master(struct sdw_bus *bus)
    > }
    > }
    >
    > + sdw_sysfs_bus_init(bus);
    > +
    > /*
    > * SDW is an enumerable bus, but devices can be powered off. So,
    > * they won't be able to report as present.
    > @@ -119,6 +121,8 @@ static int sdw_delete_slave(struct device *dev, void *data)
    > struct sdw_slave *slave = dev_to_sdw_dev(dev);
    > struct sdw_bus *bus = slave->bus;
    >
    > + sdw_sysfs_slave_exit(slave);
    > +
    > mutex_lock(&bus->bus_lock);
    > if (!list_empty(&bus->slaves))
    > list_del(&slave->node);
    > @@ -130,6 +134,7 @@ static int sdw_delete_slave(struct device *dev, void *data)
    >
    > void sdw_delete_bus_master(struct sdw_bus *bus)
    > {
    > + sdw_sysfs_bus_init(bus);

    Shouldn't this be sdw_sysfs_bus_exit() here?


    > device_for_each_child(bus->dev, NULL, sdw_delete_slave);
    > }

    \
     
     \ /
      Last update: 2017-11-09 22:15    [W:2.674 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site