Messages in this thread | | | Subject | Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK | From | Adrian Hunter <> | Date | Thu, 9 Nov 2017 09:12:35 +0200 |
| |
On 08/11/17 11:24, Linus Walleij wrote: > On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter <adrian.hunter@intel.com> wrote: > >> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >> >> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > > This patch seems OK in context, but it merely illustrates the > weirdness of .[runtime]_suspend/resume calling into CQE-specific > APIs rather than using generic host callbacks.
Your comment makes no sense at all. The host driver has [runtime]_suspend/resume callbacks and it is up to the host driver to decide what to do. CQHCI provides helpers since that is the whole point of having a CQHCI library.
| |