Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 8 Nov 2017 19:23:03 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock |
| |
On Wed, Nov 08, 2017 at 08:19:57PM +0100, Stefan Wahren wrote: > Hi Florian, > > + /* Clock is optional on most platforms */ > > + priv->clk = devm_clk_get(dev, NULL); > > + > > At least EPROBE_DEFER should be handled here: > > if (IS_ERR(priv->clk) && PTR_ERR(priv->clk) == -EPROBE_DEFER) > return -EPROBE_DEFER;
if (priv->clk == ERR_PTR(-EPROBE_DEFER)) return -EPROBE_DEFER;
is a simpler test for one particular error-pointer value.
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
| ![\](/images/icornerr.gif) |