lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock
On Wed, Nov 08, 2017 at 08:19:57PM +0100, Stefan Wahren wrote:
> Hi Florian,
> > + /* Clock is optional on most platforms */
> > + priv->clk = devm_clk_get(dev, NULL);
> > +
>
> At least EPROBE_DEFER should be handled here:
>
> if (IS_ERR(priv->clk) && PTR_ERR(priv->clk) == -EPROBE_DEFER)
> return -EPROBE_DEFER;

if (priv->clk == ERR_PTR(-EPROBE_DEFER))
return -EPROBE_DEFER;

is a simpler test for one particular error-pointer value.

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

\
 
 \ /
  Last update: 2017-11-08 21:15    [W:0.071 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site