lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops
    From
    Date
    On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote:
    > The DSA switch VLAN ops pass the switchdev_trans structure down to the
    > drivers, but no one is using them and they aren't supposed to anyway.
    []
    > diff --git a/include/net/dsa.h b/include/net/dsa.h
    []
    > @@ -410,12 +410,10 @@ struct dsa_switch_ops {
    > */
    > int (*port_vlan_filtering)(struct dsa_switch *ds, int port,
    > bool vlan_filtering);
    > - int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
    > - const struct switchdev_obj_port_vlan *vlan,
    > - struct switchdev_trans *trans);
    > - void (*port_vlan_add)(struct dsa_switch *ds, int port,
    > - const struct switchdev_obj_port_vlan *vlan,
    > - struct switchdev_trans *trans);
    > + int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
    > + const struct switchdev_obj_port_vlan *vlan);
    > + void (*port_vlan_add)(struct dsa_switch *ds, int port,
    > + const struct switchdev_obj_port_vlan *vlan);
    > int (*port_vlan_del)(struct dsa_switch *ds, int port,
    > const struct switchdev_obj_port_vlan *vlan);

    I think this bit is slightly worse.
    Mixing alignment styles seems odd.

    I think it's better to either align all the (*func) uses
    on a tabstop or
    none of them.

    \
     
     \ /
      Last update: 2017-11-08 21:13    [W:4.356 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site