Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC PATCH v10 6/7] PCI / PM: Move acpi wakeup code to pci core | Date | Wed, 08 Nov 2017 23:32:20 +0100 |
| |
On Friday, October 27, 2017 9:26:11 AM CET Jeffy Chen wrote: > Move acpi wakeup code to pci core as pci_set_wakeup(), so that other > platforms could reuse it.
What exactly do you want to reuse?
It looks like that's just several lines of code in acpi_pci_wakeup() and acpi_pci_propagate_wakeup() which invoke ACPI-specific lower-level functions, so IMO not worth it at all.
The structure for other platform code may be the same or similar, but the details will almost certainly be different and I don't think that having more callback pointers in pci_platform_pm_ops is necessarily better.
> Also add .setup_dev() / .setup_host_bridge() / .cleanup() platform pm > ops's callbacks to setup and cleanup pci devices and host bridge for > wakeup.
Why are they needed?
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Thanks, Rafael
| |