Messages in this thread | | | From | Andrey Konovalov <> | Date | Mon, 6 Nov 2017 13:30:33 +0100 | Subject | Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend |
| |
On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum <oneukum@suse.com> wrote: > Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov: >> When asix_suspend() is called dev->driver_priv might not have been >> assigned a value, so we need to check that it's not NULL. >> >> Found by syzkaller. > > Hi,
Hi Oliver,
> > 1. if that happens on suspend, it will also happen on resume
Indeed, got crashes in asix_resume() tonight as well. Mailed v2.
> 2. Will a device work after that? The appropriate fix may be to wait > until the device is properly initialized.
This shouldn't affect real devices as far as I understand. The crash can be caused by a crafted malicious device.
Go ahead if you see a better way to fix this, my patch is more of a hot fix trying to prevent the crashes.
Thanks!
> > Regards > Oliver >
| |