lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] hash addresses printed with %p
On Tue, Nov 28, 2017 at 8:59 PM, Tobin C. Harding <me@tobin.cc> wrote:
>
> git://github.com/tcharding/linux.git tags/printk-hash-pointer-4.15-rc2

Bah.

What I didn't realize until after pulling this and testing, is that it
completely breaks '%pK'.

We've marked various sensitive pointers with %pK, but that is now
_less_ secure than %p is, since it doesn't do the hashing because of
how you refactored the %pK code out of 'pointer()' into its own
function.

So now %pK ends up using the plain "number()" function. Reading
through the series I hadn't noticed that the refactoring ended up
messing with that.

I'll fix it up somehow.

Linus

\
 
 \ /
  Last update: 2017-11-29 20:22    [W:0.093 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site