Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 29 Nov 2017 11:22:29 -0800 | Subject | Re: [GIT PULL] hash addresses printed with %p |
| |
On Tue, Nov 28, 2017 at 8:59 PM, Tobin C. Harding <me@tobin.cc> wrote: > > git://github.com/tcharding/linux.git tags/printk-hash-pointer-4.15-rc2
Bah.
What I didn't realize until after pulling this and testing, is that it completely breaks '%pK'.
We've marked various sensitive pointers with %pK, but that is now _less_ secure than %p is, since it doesn't do the hashing because of how you refactored the %pK code out of 'pointer()' into its own function.
So now %pK ends up using the plain "number()" function. Reading through the series I hadn't noticed that the refactoring ended up messing with that.
I'll fix it up somehow.
Linus
| |