lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code
On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> > From: Ben Gainey <ben.gainey@arm.com>
> > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> > return -1;
> > }
> >
> > - flen = strlen(file) + 1;
> > + for (i = 0; i < nr_lines; ++i) {
> > + flen += strlen(file_names[i]) + 1;
> > + }
>
>
> Please follow the coding standard used in this file and in tools/perf,
> which is the kernel one.
>
> Thanks for providing instructions on how to reproduce the problem!
>
> Stephane, can you please Ack this?
>
Trying to test this but do not see the source code from example, yet.

>
> - Arnaldo

\
 
 \ /
  Last update: 2017-11-29 14:03    [W:0.075 / U:3.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site