Messages in this thread | | | Date | Wed, 29 Nov 2017 16:23:05 +1100 | From | Herbert Xu <> | Subject | Re: KASAN: use-after-free Read in aead_recvmsg |
| |
On Mon, Nov 27, 2017 at 11:29:44PM -0800, Eric Biggers wrote: > > >From 453b54793e843c0d5b8fd2d5e33fcc5427ec038e Mon Sep 17 00:00:00 2001 > From: Eric Biggers <ebiggers@google.com> > Date: Mon, 27 Nov 2017 23:23:05 -0800 > Subject: [PATCH] crypto: algif_aead - fix reference counting of null skcipher > > In the AEAD interface for AF_ALG, the reference to the "null skcipher" > held by each tfm was being dropped in the wrong place -- when each > af_alg_ctx was freed instead of when the aead_tfm was freed. As > discovered by syzkaller, a specially crafted program could use this to > cause the null skcipher to be freed while it is still in use. > > Fix it by dropping the reference in the right place. > > Fixes: 72548b093ee3 ("crypto: algif_aead - copy AAD from src to dst") > Reported-by: syzbot <syzkaller@googlegroups.com> > Cc: <stable@vger.kernel.org> # v4.14+ > Signed-off-by: Eric Biggers <ebiggers@google.com>
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |