lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 124/138] iio: light: fix improper return value
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>


    [ Upstream commit db4e5376d058af8924fafd0520a0942d92538d0e ]

    In function cm3232_reg_init(), it returns 0 even if the last call to
    i2c_smbus_write_byte_data() returns a negative value (indicates error).
    As a result, the return value may be inconsistent with the execution
    status, and the caller of cm3232_reg_init() will not be able to detect
    the error. This patch fixes the bug.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/light/cm3232.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/light/cm3232.c
    +++ b/drivers/iio/light/cm3232.c
    @@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232
    if (ret < 0)
    dev_err(&chip->client->dev, "Error writing reg_cmd\n");

    - return 0;
    + return ret;
    }

    /**

    \
     
     \ /
      Last update: 2017-11-28 12:49    [W:4.103 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site