Messages in this thread | | | From | Jim Davis <> | Date | Mon, 20 Nov 2017 12:48:35 -0700 | Subject | Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch |
| |
On Mon, Nov 20, 2017 at 9:18 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> > I am unhappy about adding a new interface > for each checker. > > The default of CHECK is "sparse", but > users can override it to use another checker. > > > > As Decumentation/dev-tools/coccinelle.rst says, > if you want to use coccinelle as a checker, > > make C=1 CHECK="scripts/coccicheck" >
I'd be nice if people could just specify CHECK and CHECKFLAGS to run their favorite checker, but currently CHECKFLAGS seems hardwired for running sparse. So something liike
make C=1 CHECK="scripts/checkpatch.pl" CHECKFLAGS="--quiet --file"
fails when checkpatch is passed lots of arguments like -D__linux__ -Dlinux -D__STDC__ . A little shell wrapper to grab the last argument in that long list is a workaround, but perhaps CHECKFLAGS should be made less sparse-specific?
-- Jim
| |