Messages in this thread | | | Date | Thu, 02 Nov 2017 23:32:38 +0100 | From | Daniel Borkmann <> | Subject | Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET |
| |
On 11/02/2017 12:05 PM, Arnd Bergmann wrote: > I ran into this link error with the latest net-next plus linux-next > trees when networking is disabled: > > kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops' > kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops' > > It seems that the code was written to deal with varying contents of > the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops > and xdp_analyzer_ops are defined in the core networking code, so adding > a check for CONFIG_NET seems appropriate here, and I've verified this with > many randconfig builds > > Fixes: 4f9218aaf8a4 ("bpf: move knowledge about post-translation offsets out of verifier") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
| |