lkml.org 
[lkml]   [2017]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] skd: use ktime_get_real_seconds()
From
Date
On 11/02/2017 05:42 AM, Arnd Bergmann wrote:
> Like many storage drivers, skd uses an unsigned 32-bit number for
> interchanging the current time with the firmware. This will overflow in
> y2106 and is otherwise safe.
>
> However, the get_seconds() function is generally considered deprecated
> since the behavior is different between 32-bit and 64-bit architectures,
> and using it may indicate a bigger problem.
>
> To annotate that we've thought about this, let's add a comment here
> and migrate to the ktime_get_real_seconds() function that consistently
> returns a 64-bit number.

Thanks Arnd, applied.

--
Jens Axboe

\
 
 \ /
  Last update: 2017-11-02 15:28    [W:0.028 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site