Messages in this thread | | | From | Rob Herring <> | Date | Thu, 2 Nov 2017 07:40:37 -0500 | Subject | Re: [PATCH V2] of: platform: Create dummy routines for !CONFIG_OF_ADDRESS |
| |
On Wed, Nov 1, 2017 at 11:48 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 01-11-17, 16:14, Rob Herring wrote: >> On Sat, Oct 28, 2017 at 03:56:46PM +0530, Viresh Kumar wrote: >> > Few routines don't have their dummy counterparts which results in build >> > failures where these routines are used without CONFIG_OF_ADDRESS >> > enabled. >> > >> > Fix those by defining the dummy versions. >> > >> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> >> > --- >> > V2: >> > - Rebased again latest rc and resolved conflicts. >> > - No comments received on V1. >> >> What's your user? > > It was the previous version of boot constraint core, though I have > moved to another helper now. > > https://marc.info/?l=linux-kernel&m=150157976217258&w=2 > > Wouldn't it be better to define them anyway?
No. As an example, ideally of_device_alloc would be an internal function. But we have one user in ibmebus.
Rob
| |