Messages in this thread | | | From | Alex Deucher <> | Date | Fri, 17 Nov 2017 14:52:45 -0500 | Subject | Re: [PATCH 2/4] drm: amd: Fix line continuation formats |
| |
On Thu, Nov 16, 2017 at 10:50 AM, Joe Perches <joe@perches.com> wrote: > On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote: >> On 2017-11-16 10:27 AM, Joe Perches wrote: >> > Line continuations with excess spacing causes unexpected output. > [] >> > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence( >> > if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) { >> > ASSERT(0); >> > dm_logger_write(link->ctx->logger, LOG_ERROR, >> > - "%s: Link Training Error, could not \ >> > - get CR after %d tries. \ >> > - Possibly voltage swing issue", __func__, >> > + "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue", >> >> Would probably be good to add a '\n' here as well but that's not the main intention of this patch. > > About 1/4 of the dm_logger_write calls are missing > newlines and I think it should be a separate patch. > > I encourage you to fix them one day. > >> Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > cheers, Joe
Applied. Thanks!
Alex
| |