Messages in this thread | | | Date | Tue, 14 Nov 2017 08:21:57 +0100 | From | Ingo Molnar <> | Subject | Re: [RESEND PATCH v2 3/4] x86/umip: Identify the str and sldt instructions |
| |
* Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
> The instructions STR and SLDT are not emulated in any case. Thus, it made > sense to not implement functionality to identify them. However, a > subsequent commit will introduce functionality to warn about the use of > all the instructions that UMIP protect, not only those that are emulated. > A first step for that is the ability to identify them. > > Plus, now that STR and SLDT are identified, we need to explicitly avoid > their emulation (i.e., not rely on unsuccessful identification). Group > togehter all the cases that we do not want to emulate: STR, SLDT and user > long mode processes. > > Cc: Andy Lutomirski <luto@kernel.org> > Cc: H. Peter Anvin <hpa@zytor.com> > Cc: Borislav Petkov <bp@suse.de> > Cc: Tony Luck <tony.luck@intel.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Ravi V. Shankar <ravi.v.shankar@intel.com> > Cc: x86@kernel.org > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Sigh, the _title_ still refers to 'str'...
I'll fix it up, no need to resend, but this lack of attention to details is seriously sad.
Thanks,
Ingo
| |