Messages in this thread | | | Date | Tue, 14 Nov 2017 08:34:57 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes |
| |
On Tue, 14 Nov 2017 16:22:05 +0100 Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
Yes, this looks like a real issue.
> + /* Query hardware capabilities if we're called from netvsc_probe() */ > + if (!net->hw_features) { > + ret = rndis_netdev_set_hwcaps(net_device, rndis_device); > + if (ret != 0) > + goto err_dev_remv; > + } > +
Rather than conditional behavior in rndis_filter_device_add, it would be cleaner to make the call to get hardware capabilities there.
Please respin and make the query of host a separate function.
| |