Messages in this thread | | | From | Gilad Ben-Yossef <> | Date | Tue, 14 Nov 2017 11:33:20 +0200 | Subject | Re: [PATCH 00/24] staging: ccree: more cleanup patches |
| |
On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > These cleanups look nice. Thanks. > > I hope you do a mass remove of likely/unlikely in a patch soon. > Whenever, I see one of those in a + line I always have to remind myself > that you're planning to do it in a later patch. >
So, a question about that - there indeed seems to be an inflation of likely/unlikely in the ccree driver, but what stopped me from removing them was that I found out I don't have a clue about when it's a good idea to use them and when it isn't (obviously in places where you know the probable code flow of course).
Any hints?
-- Gilad Ben-Yossef Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
| |