Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 14 Nov 2017 12:51:15 +0900 | Subject | Re: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck |
| |
Hi Julia,
2017-11-14 1:45 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>: > > > On Tue, 14 Nov 2017, Masahiro Yamada wrote: > >> Hi Julia, >> >> >> 2017-11-14 0:30 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>: >> > >> > >> > On Thu, 9 Nov 2017, Masahiro Yamada wrote: >> > >> >> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of >> >> "coccicheck failed" error messages. >> >> >> >> I do not know the coccinelle internals, but I guess --jobs does not >> >> work well if spatch is invoked from Make running in parallel. >> >> Disable --jobs in this case. >> > >> > Why is this change under: >> > >> > if [ "$C" = "1" -o "$C" = "2" ]; >> > >> > The coccicheck failed messages come also if one runs Coccinelle on the >> > entire kernel. >> >> As far as I tested, "coccicheck failed" error only happens >> when ONLINE=1. >> >> >> make -j8 C=1 CHECK=scripts/coccicheck COCCI=scripts/coccinelle/misc/bugon.cocci >> >> emits lots of errors. >> >> >> make -j8 coccicheck COCCI=scripts/coccinelle/misc/bugon.cocci >> >> is fine. >> >> >> Have you tested it? >> Do you mean you got a different result from mine? > > I agree with your results, with respect to the number of errors. > > julia >
So, what shall we do?
If you do not like to fix it (or you can fix coccinelle itself), I can take back this patch.
I am not a coccinelle developer, so setting USE_JOBS="no" is the best I can do.
-- Best Regards Masahiro Yamada
| |