Messages in this thread | | | Date | Mon, 13 Nov 2017 16:46:51 -0600 | From | Josh Poimboeuf <> | Subject | Re: [RFC 7/7] x86/unwind/64: Add support for the SYSENTER stack |
| |
On Fri, Nov 10, 2017 at 08:05:26PM -0800, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski <luto@kernel.org>
I would make the subject more specific and less unwinder-centric, like:
"x86/dumpstack: Add get_stack_info() support for the SYSENTER stack"
since there aren't yet any changes to the unwinders themselves (which I'm assuming will be needed once you start using the stack).
Also, at least a one-sentence description would be good.
Otherwise the patch looks good to me.
-- Josh
| |