Messages in this thread | | | Subject | Re: [PATCH] infiniband: avoid uninitialized variable warning in create_udata | From | Doug Ledford <> | Date | Mon, 13 Nov 2017 16:14:36 -0500 |
| |
On Sat, 2017-11-11 at 11:21 +0200, Leon Romanovsky wrote: > On Fri, Nov 10, 2017 at 11:10:31PM +0100, Arnd Bergmann wrote: > > As Dan pointed out, the rework I did makes it harder for smatch and other > > static checkers to figure out what is going on with the uninitialized > > pointers. > > > > By open-coding the call in create_udata(), we make it more readable for > > both humans and tools. > > > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > Fixes: 12f727721eee ("IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > drivers/infiniband/core/uverbs_std_types.c | 21 ++++++++++----------- > > 1 file changed, 10 insertions(+), 11 deletions(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Thanks, applied.
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD[unhandled content-type:application/pgp-signature] | |