lkml.org 
[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 23/56] IB/ipoib: Change list_del to list_del_init in the tx object
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Feras Daoud <ferasda@mellanox.com>


    [ Upstream commit 27d41d29c7f093f6f77843624fbb080c1b4a8b9c ]

    Since ipoib_cm_tx_start function and ipoib_cm_tx_reap function
    belong to different work queues, they can run in parallel.
    In this case if ipoib_cm_tx_reap calls list_del and release the
    lock, ipoib_cm_tx_start may acquire it and call list_del_init
    on the already deleted object.
    Changing list_del to list_del_init in ipoib_cm_tx_reap fixes the problem.

    Fixes: 839fcaba355a ("IPoIB: Connected mode experimental support")
    Signed-off-by: Feras Daoud <ferasda@mellanox.com>
    Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
    Reviewed-by: Alex Vesker <valex@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
    +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
    @@ -1373,7 +1373,7 @@ static void ipoib_cm_tx_reap(struct work

    while (!list_empty(&priv->cm.reap_list)) {
    p = list_entry(priv->cm.reap_list.next, typeof(*p), list);
    - list_del(&p->list);
    + list_del_init(&p->list);
    spin_unlock_irqrestore(&priv->lock, flags);
    netif_tx_unlock_bh(dev);
    ipoib_cm_tx_destroy(p);

    \
     
     \ /
      Last update: 2017-11-13 14:36    [W:4.806 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site