Messages in this thread | | | Subject | Re: [PATCH v4 1/5] ARM: tegra: Add device tree node to describe IRAM | From | Dmitry Osipenko <> | Date | Sun, 12 Nov 2017 19:28:06 +0300 |
| |
On 11.11.2017 17:18, Vladimir Zapolskiy wrote: > Hi Dmitry, > > On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: >> From: Vladimir Zapolskiy <vz@mleia.com> >> >> All Tegra SoCs contain 256KiB IRAM, which is used to store CPU resume code >> and by hardware engines like a video decoder. >> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > > Please add also your own closing "Signed-off-by" tag, please reference > to "Developer's Certificate of Origin 1.1", point (c), it is found in > Documentation/process/submitting-patches.rst >
Indeed, thanks!
>> --- >> arch/arm/boot/dts/tegra114.dtsi | 8 ++++++++ >> arch/arm/boot/dts/tegra124.dtsi | 8 ++++++++ >> arch/arm/boot/dts/tegra20.dtsi | 8 ++++++++ >> arch/arm/boot/dts/tegra30.dtsi | 8 ++++++++ > > My assumption is that Thierry would prefer to get 4 separate patches, > one for each platform, please split the patch. >
Thierry, would you?
> Also thanks for your time and your efforts applied to push my occasional > change, please feel free to take your own authorship for 3 out of 4 patches. >
Okay.
>> 4 files changed, 32 insertions(+) >> >> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi >> index 8932ea3afd5f..13f6087790c8 100644 >> --- a/arch/arm/boot/dts/tegra114.dtsi >> +++ b/arch/arm/boot/dts/tegra114.dtsi >> @@ -10,6 +10,14 @@ >> compatible = "nvidia,tegra114"; >> interrupt-parent = <&lic>; >> >> + iram@40000000 { >> + compatible = "mmio-sram"; > > Unfortunately Thierry hasn't yet replied, but my assumption is that > the list of compatibles should be extended with one more SoC specific > value like > > compatible = "nvidia,tegra114-sysram", "mmio-sram"; > > I'm not sure, if Tegra maintainers want to see a new compatible > described in Documentation/devicetree/bindings. >
The custom compatible string shouldn't be needed. AFAIK, IRAM doesn't have any exposed controls, so just a generic "mmio-sram" suits well here.
>> + reg = <0x40000000 0x40000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0 0x40000000 0x40000>; >> + }; >> + >> host1x@50000000 { >> compatible = "nvidia,tegra114-host1x", "simple-bus"; >> reg = <0x50000000 0x00028000>; >> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi >> index 8baf00b89efb..a3585ed82646 100644 >> --- a/arch/arm/boot/dts/tegra124.dtsi >> +++ b/arch/arm/boot/dts/tegra124.dtsi > > The considerations from above are applicable to the rest of > the touched platforms.
| |