Messages in this thread | | | Subject | Re: [PATCH] of: Document exactly what of_find_node_by_name() puts | From | Randy Dunlap <> | Date | Fri, 10 Nov 2017 18:12:44 -0800 |
| |
On 11/10/2017 05:45 PM, Stephen Boyd wrote: > It isn't clear if this function of_node_put()s the 'from' > argument, or the node it finds in the search. Clearly indicate > which variable is touched. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 63897531cd75..602c5d65734a 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node
* @from: The node to start searching from or %NULL; the node
> * you pass will not be searched, only the next one > * will; typically, you pass what the previous call
* will. Typically, you pass what the previous call
> - * returned. of_node_put() will be called on it > + * returned. of_node_put() will be called on @from. > * @name: The name string to match against > * > * Returns a node pointer with refcount incremented, use >
-- ~Randy
| |