Messages in this thread | | | Subject | Re: [PATCH 20/30] x86, mm: remove hard-coded ASID limit checks | From | Dave Hansen <> | Date | Fri, 10 Nov 2017 10:41:26 -0800 |
| |
On 11/10/2017 04:20 AM, Peter Zijlstra wrote: > On Wed, Nov 08, 2017 at 11:47:24AM -0800, Dave Hansen wrote: >> +#define CR3_HW_ASID_BITS 12 >> +#define NR_AVAIL_ASIDS ((1<<CR3_AVAIL_ASID_BITS) - 1) > That evaluates to 4095 > >> - VM_WARN_ON_ONCE(asid > 4094); >> + VM_WARN_ON_ONCE(asid > NR_AVAIL_ASIDS); > Not the same number
I think this got fixed up in the next patch (the check becomes a >=), but I'll fix this to make it more clean and fix the intermediate breakage.
| |