Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi() | From | SF Markus Elfring <> | Date | Wed, 1 Nov 2017 09:57:00 +0100 |
| |
> This is fine by me
Thanks for another bit of change acceptance.
> except that the change in the name of the goto label seems spurious.
I am curious if the popularity of a jump label like “err” will decrease (in the Linux source files) over time.
> But if you really want to change it then as it is an error path > I should suggest it describe that its an error and what unwinding > is done, f.e. err_remove_domain.
* Do you get such a kind of information only when the prefix “err_” is added to this identifier?
* Do you prefer to stress the “domain removal” (or the shown error message) in the label?
Regards, Markus
| ![\](/images/icornerr.gif) |