lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()
From
Date
> This is fine by me

Thanks for another bit of change acceptance.


> except that the change in the name of the goto label seems spurious.

I am curious if the popularity of a jump label like “err” will decrease
(in the Linux source files) over time.


> But if you really want to change it then as it is an error path
> I should suggest it describe that its an error and what unwinding
> is done, f.e. err_remove_domain.

* Do you get such a kind of information only when the prefix “err_”
is added to this identifier?

* Do you prefer to stress the “domain removal”
(or the shown error message) in the label?

Regards,
Markus

\
 
 \ /
  Last update: 2017-11-01 09:57    [W:0.041 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site