lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 102/139] net: phy: fix marvell phy status reading
    Date
    From: Russell King <rmk+kernel@armlinux.org.uk>

    commit 898805e0cdf7fd860ec21bf661d3a0285a3defbd upstream.

    The Marvell driver incorrectly provides phydev->lp_advertising as the
    logical and of the link partner's advert and our advert. This is
    incorrect - this field is supposed to store the link parter's unmodified
    advertisment.

    This allows ethtool to report the correct link partner auto-negotiation
    status.

    Fixes: be937f1f89ca ("Marvell PHY m88e1111 driver fix")
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/net/phy/marvell.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
    index 202fe1f..b23f36a 100644
    --- a/drivers/net/phy/marvell.c
    +++ b/drivers/net/phy/marvell.c
    @@ -656,8 +656,6 @@ static int marvell_read_status(struct phy_device *phydev)
    if (adv < 0)
    return adv;

    - lpa &= adv;
    -
    if (status & MII_M1011_PHY_STATUS_FULLDUPLEX)
    phydev->duplex = DUPLEX_FULL;
    else
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-11-01 22:37    [W:4.072 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site