lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] [RFC] blk-mq: fix queue stalling on shared hctx restart
Date
On Mon, 2017-10-23 at 17:12 +0200, Roman Penyaev wrote:
> On Fri, Oct 20, 2017 at 10:05 PM, Bart Van Assche wrote:
> > Commit 6d8c6c0f97ad is something I came up with to fix queue lockups in the
> > SCSI and dm-mq drivers.
>
> You mean fairness? (some hctx get less amount of chances to be restarted).
> That's why you need to restart them in RR fashion, right?

Commit 6d8c6c0f97ad not only improved fairness but also fixed a lockup scenario.
After a driver tag has been freed not only the hw queues of the request queue for
which a request completed must be reexamined but also the hw queues associated
with the other request queues that share the same tag set.

Bart.
\
 
 \ /
  Last update: 2017-11-01 17:51    [W:0.098 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site