lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] pinctrl: sunxi: Disable strict mode for old pinctrl drivers
Hi,

On Fri, Oct 06, 2017 at 08:34:07AM +0000, Chen-Yu Tsai wrote:
> On Fri, Oct 6, 2017 at 4:54 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Old pinctrl drivers will need to disable strict mode for various reasons,
> > among which:
> > - Some DT will still have a pinctrl group for each GPIO used, which will
> > be rejected by pin_request. While we could remove those nodes, we still
> > have to deal with old DTs.
> > - Some GPIOs on these boards need to have their pin configuration changed
> > (for bias or current), and there's no clear migration path
> >
> > Let's disable the strict mode on those SoCs so that there's no breakage.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> > drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 1 +
> > drivers/pinctrl/sunxi/pinctrl-sun5i.c | 1 +
> > drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c | 1 +
> > drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c | 1 +
> > drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c | 1 +
> > drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 3 ++-
> > drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c | 1 +
>
> You should also set it for the R_PIO drivers. IIRC you removed some
> entries for them in your other patchset.

I'll look into the R_PIO that can be switched on, but we won't be able
to enable that flag on the one where we removed nodes.

That would break the old DTs.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-09 10:46    [W:0.073 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site