lkml.org 
[lkml]   [2017]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison
    Isn't this bogus?

    "bool" type in Linux kernel is a typedef to "_Bool"
    and true/false is defined as 1 and 0 by enum at include/linux/stddef.h.

    On Sat, Oct 7, 2017 at 11:02 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
    > Bool initializations should use true and false. Bool tests don't need
    > comparisons.
    >
    > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
    > ---
    >
    > diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c
    > --- a/fs/f2fs/data.c
    > +++ b/fs/f2fs/data.c
    > @@ -419,7 +419,7 @@ next:
    > bio_page = fio->encrypted_page ? fio->encrypted_page : fio->page;
    >
    > /* set submitted = 1 as a return value */
    > - fio->submitted = 1;
    > + fio->submitted = true;
    >
    > inc_page_count(sbi, WB_DATA_TYPE(bio_page));
    >
    >
    > ------------------------------------------------------------------------------
    > Check out the vibrant tech community on one of the world's most
    > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
    > _______________________________________________
    > Linux-f2fs-devel mailing list
    > Linux-f2fs-devel@lists.sourceforge.net
    > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

    \
     
     \ /
      Last update: 2017-10-07 16:34    [W:2.210 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site