lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN
    On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:
    >
    > diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c
    > index 5e92bd2..3b3c154 100644
    > --- a/crypto/algif_hash.c
    > +++ b/crypto/algif_hash.c
    > @@ -39,6 +39,20 @@ struct algif_hash_tfm {
    > bool has_key;
    > };
    >
    > +/* Previous versions of crypto_* ops used to return -EBUSY
    > + * rather than -EAGAIN to indicate being tied up. The in
    > + * kernel API changed but we don't want to break the user
    > + * space API. As only the hash user interface exposed this
    > + * error ever to the user, do the translation here.
    > + */
    > +static inline int crypto_user_err(int err)
    > +{
    > + if (err == -EAGAIN)
    > + return -EBUSY;
    > +
    > + return err;

    I don't see the need to carry along this baggage. Does anyone
    in user-space actually rely on EBUSY?

    Cheers,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2017-10-07 05:08    [W:2.159 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site