lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 038/104] drm/amdkfd: fix improper return value on error
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>


    [ Upstream commit 8bf793883da213864efc50c274d2b38ec0ca58b2 ]

    In function kfd_wait_on_events(), when the call to copy_from_user()
    fails, the value of return variable ret is 0. 0 indicates success, which
    is inconsistent with the execution status. This patch fixes the bug by
    assigning "-EFAULT" to ret when copy_from_user() returns an unexpected
    value.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/amd/amdkfd/kfd_events.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/amd/amdkfd/kfd_events.c
    +++ b/drivers/gpu/drm/amd/amdkfd/kfd_events.c
    @@ -739,8 +739,10 @@ int kfd_wait_on_events(struct kfd_proces
    struct kfd_event_data event_data;

    if (copy_from_user(&event_data, &events[i],
    - sizeof(struct kfd_event_data)))
    + sizeof(struct kfd_event_data))) {
    + ret = -EFAULT;
    goto fail;
    + }

    ret = init_event_waiter(p, &event_waiters[i],
    event_data.event_id, i);

    \
     
     \ /
      Last update: 2017-10-06 11:38    [W:4.052 / U:0.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site