lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()
    On 2017-10-05 18:30:19 [+0200], To Arnaldo Carvalho de Melo wrote:
    > On 2017-10-03 12:49:19 [-0300], Arnaldo Carvalho de Melo wrote:
    > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
    > >
    > > diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c
    > > index 615be68e40b3..3a30bde9a07b 100644
    > > --- a/drivers/infiniband/hw/hfi1/pio.c
    > > +++ b/drivers/infiniband/hw/hfi1/pio.c
    > > @@ -1421,7 +1421,7 @@ struct pio_buf *sc_buffer_alloc(struct send_context *sc, u32 dw_len,
    > >
    > > /* there is enough room */
    > >
    > > - preempt_disable();
    > > + preempt_disable_nort();
    > > this_cpu_inc(*sc->buffers_allocated);
    > >
    > > /* read this once */
    >
    > please replace the preempt_disable() / enable with local_lock() /
    > unlock. The section does not look like it could cope with multiple users
    > dereferencing / using the same per-CPU variables.

    ignore me, there is a spin_lock to protect that…

    Sebastian

    \
     
     \ /
      Last update: 2017-10-06 11:20    [W:5.345 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site